elf-raw-dylib: set type for functions#153090
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 2, 2026
Merged
Conversation
Avoids GNU ld warnings like: ``` type and size of dynamic symbol `meooooooooooooooow' are not defined ``` First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
rustbot
added
S-waiting-on-author
bjorn3
reviewed
Feb 25, 2026
| stub.write_null_dynamic_symbol(); | ||
| for (_name, dynstr, _ver) in syms.iter().copied() { | ||
| for (_name, dynstr, _ver, is_fn) in syms.iter().copied() { | ||
| let sym_type = if is_fn { elf::STT_FUNC } else { elf::STT_NOTYPE }; |
Member
There was a problem hiding this comment.
Should we use STT_OBJECT for statics and STT_TLS for #[thread_local] statics?
Member
Author
There was a problem hiding this comment.
Yeah, I was wondering whether STT_OBJECT is important. Even though it doesn't matter for Wild, it might be useful for other linkers.
Good point about TLS. I forgot about it, but it's relevant.
I'd see those changes as follow-ups (let me know if you want to take care of it). This change is a low-hanging fruit to quickly help with #149937.
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
TaKO8Ki
approved these changes
Mar 2, 2026
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 2, 2026
elf-raw-dylib: set type for functions Avoids GNU ld warnings like: ``` type and size of dynamic symbol `meooooooooooooooow' are not defined ``` First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2026
…uwer Rollup of 6 pull requests Successful merges: - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153046 (Couple of cg_ssa refactorings) - #153090 (elf-raw-dylib: set type for functions) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)
rust-timer
added a commit
that referenced
this pull request
Mar 2, 2026
Rollup merge of #153090 - mati865:elf-raw-dylib-fns, r=TaKO8Ki elf-raw-dylib: set type for functions Avoids GNU ld warnings like: ``` type and size of dynamic symbol `meooooooooooooooow' are not defined ``` First noticed in #152451 (comment) with changes from #149937.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids GNU ld warnings like:
First noticed in #152451 (comment) with changes from #149937.